They don't need to be pretty to catch fish. Not bad, but could use some refinement. The materials you're using, likely even the foam is absorbing water after awhile & that's why they start to sink. You can either go to a different foam, or other body, or just change poppers more often, which means you need to make more of them.
Personally I like a wider & shorter tail. This is about proportion. I also gave up on threading legs thru the body many years ago, as I damaged a lot of bodies & that extra hole may be contributing to your sinking issue. I'm not a fan of the leg material you're using (rubber band?) either as it seems too thick for your popper size. I generally use jig skirt material, either round rubber or silicone, and I tie them in behind the body. Much easier to do, & when punching holes thru the body not always easy to get the holes straight across so there's good balance from one side to the other. Too far off & the popper might sit cocked to one side or cause it to roll.
Here's a popper I made several months ago. It's using a ready made soft foam body I had purchased, but the general idea for making poppers is the same. I also prefer epoxy to mount the body on the hook & do that before tying on the rest of the materials. Super glues do work, but are not really water proof and I try to make them as durable as I can. However, I always start with a good thread base along the hook shank. By doing as I do it, I can make a lot of bodies mounted on hooks & tie them later as I have time or inclination.
This particular popper is on a offset worm hook, Owner brand in a 1/0 size if I recall correctly. Th offset acts like the kink on a kink shank popper hook & helps keep the body from ever rotating. It's a little tricky getting the hook positioned correctly, but works. It also causes the hook point to be positioned a bit lower & at an upwards angle, which I like as I feel it improves my hook up ratio. Notice also where the hook point is relative to the back end of the body. This hook has plenty of gap & is far enough back so fish (bass mostly) will get the hook in their mouth.
Take note of the proportions. Length of the tail & width of the tail feathers & such and how & where I added the legs. There's a bit of marabou to in the tail, which is another possible way to make them. I make most of mine with splayed out feather tails as I like how they "kick" when retrieved. Not the only way to make a popper, but for me it's worked well. I usually use a black hackle collar as black works great with any color body I choose. I use strung saddle or neck hackle for the collar & often leave some of the fluffy, marabou looking fibers as you see in the pics.
The eyes I used can be found in many crafts stores. They have a stem on the back, and I cut it a little short, punch a hole in the foam & glue the eye in place, which seals the hole. I don't usually punch the hole completely thru the body. Isn't necessary but I like how eyes look.
BTW, welcome to these forums!